Skip to content

Fix scripts for yarn start. Update devDependencies #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 22, 2019
Merged

Fix scripts for yarn start. Update devDependencies #25

merged 2 commits into from
May 22, 2019

Conversation

hidde-vb
Copy link
Contributor

I noticed that yarn start was missing from the script in package.json. I've added a script that reflects the current readme.

Also bumped babel-loader to 8.0.5 because it's needed react-scripts 3.0.0.

Thanks!

@swyxio
Copy link
Contributor

swyxio commented May 22, 2019

thanks! unfortunately we want to keep the yarn start separate from yarn start:lambda to ensure compatibility for netlify dev :) i'll just update the readme instead

@swyxio swyxio merged commit 93d2def into netlify:master May 22, 2019
@hidde-vb
Copy link
Contributor Author

Thanks for taking a look at my PR! The package npm-run-all is not used anymore then?

A simple solution might be to rename the script to yarn start:all or yarn start:stack or something so the script can be kept. And it would only require a small update in the readme.

@swyxio
Copy link
Contributor

swyxio commented May 23, 2019

yeah its not needed for netlify-dev but you can still use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hidde-vb @swyxio